-
Notifications
You must be signed in to change notification settings - Fork 32
Use EDOT sdk #2208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Use EDOT sdk #2208
Conversation
| options.TemporalityPreference = MetricReaderTemporalityPreference.Delta; | ||
| }); | ||
|
|
||
| _ = builder.Services.AddOpenTelemetry().UseOtlpExporter(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This creates a new OTLP Exporter, breaking integration testing (and I'd assume live).
The reason it creates a new one is that an implicit default ElasticOpenTelemetryOptions has its SkipOtlpExporter set to false. Also, this starts a new OpenTelemetry service which is already defined in the beginning of ConfigureOpenTelemetry, is this wanted?
|
Suggestion for ConfigureOpenTelemetry (passes integration): |
No description provided.